Upgrade NeoFS SDK module to the latest revision #2449
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2449 +/- ##
==========================================
- Coverage 29.48% 29.46% -0.02%
==========================================
Files 399 399
Lines 30430 30425 -5
==========================================
- Hits 8973 8966 -7
- Misses 20713 20716 +3
+ Partials 744 743 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cthulhu-rider
force-pushed
the
upgrade-sdk-latest
branch
2 times, most recently
from
a896f36
to
babfcc3
Compare
|
protocol details are deeply rooted in the metabase implementation. Because this is a root and change-sensitive component, it needs to be edited more carefully |
| @@ -34,13 +34,12 @@ var accountingBalanceCmd = &cobra.Command{ | |||
|
|
|||
| balanceOwner, _ := cmd.Flags().GetString(ownerFlag) | |||
| if balanceOwner == "" { | |||
| err := user.IDFromSigner(&idUser, neofsecdsa.SignerRFC6979(*pk)) | |||
| common.ExitOnErr(cmd, "decoding user from key", err) | |||
| idUser.SetScriptHash((*keys.PublicKey)(&pk.PublicKey).GetScriptHash()) | |||
There was a problem hiding this comment.
This row is a good candidate to be moved to a separate function inside the user package because there are few places in the code, which look too similar
There was a problem hiding this comment.
yeah but we dropped "user from key" function, so, looks like it needs to be resurrected
There was a problem hiding this comment.
was added by nspcc-dev/neofs-sdk-go@6ab5d39, so now i can adopt it
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
upgrade-sdk-latest
branch
from
babfcc3
to
aed298d
Compare
decided to have up-to-date SDK changes here to simplify debug and prepare for https://github.com/nspcc-dev/neofs-sdk-go/milestone/5